ref: Add ruff rules for bugbear (B) #3983
Conversation
dosubot
bot
added
size:L
| @@ -63,6 +63,6 @@ def create_state_model_from_graph(graph: BaseModel) -> type[BaseModel]: | |||
| ] | |||
| fields = { | |||
| camel_to_snake(vertex.id): state_model_getter | |||
| for vertex, state_model_getter in zip(graph.vertices, state_model_getters) | |||
| for vertex, state_model_getter in zip(graph.vertices, state_model_getters, strict=False) | |||
There was a problem hiding this comment.
Reading the code, it seems graph.vertices and state_model_getters could have distinct size. Is it intended ?
There was a problem hiding this comment.
Yeah. We probably need to add the same checks on the second iteration or just build the fields dict in one go.
There was a problem hiding this comment.
This part is still highly experimental and requires a lot more testing/inclusion into features
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
cbornet
force-pushed
the
ruff-rules-b-2
branch
2 times, most recently
from
7529086
to
c152424
Compare
cbornet
force-pushed
the
ruff-rules-b-2
branch
2 times, most recently
from
f5b1b2a
to
6d6a658
Compare
cbornet
changed the title
|
@ogabrielluiz thanks for the review. |
cbornet
force-pushed
the
ruff-rules-b-2
branch
5 times, most recently
from
e7020ed
to
36ebdfd
Compare
cbornet
force-pushed
the
ruff-rules-b-2
branch
from
36ebdfd
to
8305036
Compare
No description provided.