feat: Add ruff rules SIM #3979
Merged
feat: Add ruff rules SIM #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
cbornet
force-pushed
the
ruff-rules-sim
branch
from
bbfb753
to
5b76f67
Compare
jordanrfrazier
approved these changes
Oct 1, 2024
| vertex_id = self._vertex.id | ||
| else: | ||
| vertex_id = self.display_name or self.__class__.__name__ | ||
| vertex_id = self._vertex.id if self._vertex else self.display_name or self.__class__.__name__ |
There was a problem hiding this comment.
This simplification, imo, is a bit harder to read in certain cases. Don't mind it enough to change, unless others had opinions too.
There was a problem hiding this comment.
This is the rule : https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp/
A matter of taste probably...
cbornet
force-pushed
the
ruff-rules-sim
branch
from
5b76f67
to
76611a3
Compare
cbornet
force-pushed
the
ruff-rules-sim
branch
from
76611a3
to
fb8ce53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.