Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pre-commit hook for ruff #3960

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 30, 2024

No description provided.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 30, 2024
@cbornet cbornet changed the title Add pre-commit hook for ruff feat: Add pre-commit hook for ruff Sep 30, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3960.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added the enhancement New feature or request label Sep 30, 2024
@cbornet cbornet force-pushed the pre-commit branch 2 times, most recently from 597623f to 997e950 Compare September 30, 2024 16:01
@cbornet
Copy link
Collaborator Author

cbornet commented Sep 30, 2024

Not using make format as the js formatting takes too long.

@ogabrielluiz
Copy link
Contributor

Hey, @cbornet

If want you can update the commit/ci setup to use pre-commit (i.e https://pre-commit.ci/) instead of the autofix stuff.

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2024
@cbornet cbornet merged commit b11207b into langflow-ai:main Oct 1, 2024
15 of 16 checks passed
@cbornet cbornet deleted the pre-commit branch October 1, 2024 10:50
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants