Fix: Ensure Full Image Path Resolution for LLMs #3955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he directory for image files 🐛 (image.py): fix file_path assignment to include cache_dir path for image verification
dosubot
bot
added
size:XS
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
github-actions
bot
added
bug
Cristhianzl
changed the title
github-actions
bot
added
bug
ogabrielluiz
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Hey @Cristhianzl
I don't think this is correct. We should try to understand why file_path isn't correct any more.
…prove code readability 📝 (message.py): Add synchronous version of get_file_paths function to improve performance 📝 (service.py): Implement build_full_path method to construct full file path in the local storage
dosubot
bot
added
size:S
you are right. please check this PR #3980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 (image.py): import user_cache_dir from platformdirs to create a cache directory for image files
🐛 (image.py): fix file_path assignment to include cache_dir path for image verification
Problem
The LLMs were unable to process images due to issues locating the relative path. This caused the image to not be interpreted or processed correctly by the LLMs.
Solution
This PR introduces a finder that resolves the full path of the image, ensuring that the LLM can correctly locate and interpret the image. By converting the relative image path to an absolute path, we eliminate the path resolution issue and allow the LLM to process images as intended.