Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: improve tests of store #3949

Merged
merged 1 commit into from
Sep 27, 2024
Merged

tests: improve tests of store #3949

merged 1 commit into from
Sep 27, 2024

Conversation

Cristhianzl
Copy link
Collaborator

✨ (store-shard-1.spec.ts): Improve test case for liking and adding components and flows by adding more specific selectors and reducing timeout durations for better performance and reliability

✨ (store-shard-3.spec.ts): Enhance test case for filtering by type by adding more specific selectors and reducing timeout durations for better performance and reliability

…mponents and flows by adding more specific selectors and reducing timeout durations for better performance and reliability

✨ (store-shard-3.spec.ts): Enhance test case for filtering by type by adding more specific selectors and reducing timeout durations for better performance and reliability
@Cristhianzl Cristhianzl self-assigned this Sep 27, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Sep 27, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3949.dmtpw4p5recq1.amplifyapp.com

@Cristhianzl Cristhianzl requested review from italojohnny and removed request for lucaseduoli and anovazzi1 September 27, 2024 16:27
@Cristhianzl Cristhianzl changed the title tests: improve tests on store tests: improve tests of store Sep 27, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) September 27, 2024 16:30
@ogabrielluiz ogabrielluiz merged commit 8facb67 into main Sep 27, 2024
45 of 47 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fix-tests-store branch September 27, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants