Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add components_only parameter to filter flows by components in API endpoint #3932

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request adds a new components_only parameter to the read_flows API endpoint. When set to True, this parameter allows filtering the returned flows to only include components. This is useful when you only want to retrieve flows that are components and exclude other types of flows.

The changes include adding the components_only parameter to the function signature, updating the database query to filter flows based on the parameter value, and adding a test case to ensure the correct behavior.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Sep 26, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 26, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3932.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) September 27, 2024 12:08
- Enhanced assertion in `test_database.py` to include flow names for better debugging.
- Removed redundant assertions in `conftest.py` to streamline the test setup process.
@ogabrielluiz ogabrielluiz merged commit 35d81b7 into main Sep 27, 2024
28 checks passed
@ogabrielluiz ogabrielluiz deleted the feat/get-components branch September 27, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants