Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove bson import #3924

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: remove bson import #3924

merged 1 commit into from
Sep 26, 2024

Conversation

jordanrfrazier
Copy link
Collaborator

@jordanrfrazier jordanrfrazier commented Sep 26, 2024 •
edited
Loading

pymongo includes a bson implementation built-in. installing bson explicitly will cause conflicts. https://pymongo.readthedocs.io/en/stable/installation.html

Closes #3912

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. python Pull requests that update Python code labels Sep 26, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 26, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 26, 2024
ogabrielluiz
ogabrielluiz approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) September 26, 2024 11:26
@ogabrielluiz ogabrielluiz merged commit 17cc9ba into main Sep 26, 2024
44 of 46 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-mongo-dep-conflict branch September 26, 2024 11:46
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
@jordanrfrazier @diogocabral
fix: remove bson import (langflow-ai#3924)
f751ae9 
Remove bson import
@italojohnny italojohnny mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@phact phact Awaiting requested review from phact

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict with pymongo and bson packages in MongoDB VectorStore Component
2 participants
@jordanrfrazier @ogabrielluiz