Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security file upload #3923

Merged
merged 4 commits into from
Sep 30, 2024
Merged

fix: security file upload #3923

merged 4 commits into from
Sep 30, 2024

Conversation

italojohnny
Copy link
Member

@italojohnny italojohnny commented Sep 26, 2024

This PR fixes security vulnerabilities:

  • File uploads without user authentication
  • check boundary

@github-actions github-actions bot added the bug Something isn't working label Sep 26, 2024
@italojohnny italojohnny force-pushed the fix/security_file_upload branch from 0435b3c to ed9c890 Compare September 26, 2024 03:35
@italojohnny italojohnny marked this pull request as ready for review September 26, 2024 03:40
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 26, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@italojohnny
Copy link
Member Author

I'm still looking into this

@italojohnny italojohnny force-pushed the fix/security_file_upload branch from ed9c890 to bd4cd50 Compare September 30, 2024 05:44
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 30, 2024
@italojohnny italojohnny force-pushed the fix/security_file_upload branch from bb9ed08 to 1c39ab1 Compare September 30, 2024 05:46
@italojohnny italojohnny enabled auto-merge (squash) September 30, 2024 05:47
@italojohnny italojohnny force-pushed the fix/security_file_upload branch from 1c39ab1 to 09c79b9 Compare September 30, 2024 05:49
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 30, 2024
@italojohnny italojohnny force-pushed the fix/security_file_upload branch from 09c79b9 to c35fbe8 Compare September 30, 2024 06:07
fix: add request header size validation

Revert "fix: add request header size validation"

This reverts commit ed9c890.
@italojohnny italojohnny force-pushed the fix/security_file_upload branch 2 times, most recently from 3b31fc4 to ed9c890 Compare September 30, 2024 18:37
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
@italojohnny italojohnny force-pushed the fix/security_file_upload branch from ed9c890 to 3b31fc4 Compare September 30, 2024 18:37
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 30, 2024
…rence of text is visible instead of the first one
@italojohnny italojohnny merged commit f873309 into main Sep 30, 2024
28 checks passed
@italojohnny italojohnny deleted the fix/security_file_upload branch September 30, 2024 19:14
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* fix: add check user authentication
* fix: add request body multipart boundary validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants