Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary re-renders in PageComponent and update edgeTypes #3917

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request fixes an issue in the PageComponent where unnecessary re-renders were occurring. The edgeTypes in the PageComponent have also been updated to use a constant object instead of hardcoding the value. This improves code readability and maintainability.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 25, 2024
@dosubot dosubot bot added the bug Something isn't working label Sep 25, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 25, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2024
@ogabrielluiz ogabrielluiz merged commit 106a34d into main Sep 26, 2024
33 of 35 checks passed
@ogabrielluiz ogabrielluiz deleted the removeNewEdgeWarning branch September 26, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants