Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usePatchUpdateFlow to conditionally refetch queries based on the browser URL #3915

Merged
merged 8 commits into from
Sep 27, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request fixes the usePatchUpdateFlow function to only refetch queries when the browser URL do not contains "/flow". This prevents unnecessary requests and improves performance.

@anovazzi1 anovazzi1 marked this pull request as ready for review September 25, 2024 18:56
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Sep 25, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 25, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3915.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 27, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@anovazzi1 anovazzi1 merged commit 5dec9cc into main Sep 27, 2024
26 of 27 checks passed
@anovazzi1 anovazzi1 deleted the fixRefetchFolders branch September 27, 2024 15:12
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
… browser URL (langflow-ai#3915)

* fix usePatchUpdateFlow to conditionally refetch queries based on the browser URL, preventing unecessary request

* [autofix.ci] apply automated fixes

* Refactor PageComponent to remove unnecessary query using useQueryClient

* Refactor usePatchUpdateFlow to conditionally refetch queries based on the browser URL

* [autofix.ci] apply automated fixes

* Refactor PageComponent to remove unnecessary query using useQueryClient

* Implement query cache cleanup on MainPage unmount

* fix spelling

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants