-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add env support for Astra Db components #3908
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mfortman11
What do you think about adding this as an advanced dropdown? Then you can set the default value to "prod" and it work similarly to this but will allow the user to change this param from the UI
Changes have been made so now env var is needed and the correct value is passed w/o user input |
@ogabrielluiz this one should be fully ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
To test:
use and Astra component (not on this branch)
try to connect to a dev or test db it should fail
Test again on this branch it will auto identify the Astra environment