Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env support for Astra Db components #3908

Merged
merged 15 commits into from
Sep 27, 2024

Conversation

mfortman11
Copy link
Collaborator

@mfortman11 mfortman11 commented Sep 24, 2024

To test:

use and Astra component (not on this branch)

try to connect to a dev or test db it should fail
Screenshot 2024-09-24 at 4 39 46 PM

Test again on this branch it will auto identify the Astra environment

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Sep 24, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3908.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mfortman11

What do you think about adding this as an advanced dropdown? Then you can set the default value to "prod" and it work similarly to this but will allow the user to change this param from the UI

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@mfortman11
Copy link
Collaborator Author

Changes have been made so now env var is needed and the correct value is passed w/o user input

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 26, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 26, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 27, 2024
@mfortman11
Copy link
Collaborator Author

@ogabrielluiz this one should be fully ready now

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@mfortman11 mfortman11 enabled auto-merge (squash) September 27, 2024 20:30
@mfortman11 mfortman11 merged commit e181624 into langflow-ai:main Sep 27, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants