chore: uv to replace poetry #3900
Conversation
dosubot
bot
added
size:L
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
dosubot
bot
added
lgtm
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
- Replace `poetry-core` with `hatchling` in build-system requirements - Update `langflow-base` dependency to version `0.0.96` - Add `tool.hatch.build.targets.wheel` configuration - Adjust `tool.uv.sources` paths for `langflow-frontend` and `langflow-base`
| requires-python = ">=3.10,<3.13" | ||
| # Define your main dependencies here | ||
| dependencies = [ | ||
| "langflow-base==0.0.96", # Local editable package |
There was a problem hiding this comment.
How does this work if I run python -m langflow run in my repo - does it use the pinned 0.0.96 version from pypi or the path from the tool.uv.sources above?
There was a problem hiding this comment.
Good eyes, I think we want:
"langflow-base @ file://./src/backend/base", # Local editable package
which is what I had originally in here but I don't know if we have a good way of keeping it from getting accidentally committed. uv seems to replace it with the 0.0.96 base automatically when we build.
There was a problem hiding this comment.
This was fixed. It has to be the version but then add it as a workspace package
There was a problem hiding this comment.
This file is still needed to update dependencies for the poetry version during docker builds - https://github.com/langflow-ai/langflow/blob/main/docker/build_and_push.Dockerfile#L54
Can we bring this back? Was it causing issues?
There was a problem hiding this comment.
There was a problem hiding this comment.
@ogabrielluiz is the plan to update docker too?
| - name: Run unit tests | ||
| uses: nick-fields/retry@v3 | ||
| with: | ||
| timeout_minutes: 12 | ||
| max_attempts: 2 | ||
| command: make unit_tests async=false args="--splits ${{ matrix.splitCount }} --group ${{ matrix.group }}" | ||
| - name: Minimize uv cache | ||
| run: uv cache prune --ci |
There was a problem hiding this comment.
I see the install uv -> python -> restore -> install project .. -> minimize steps repeated a few times. Can we move that to a sub workflow?
There was a problem hiding this comment.
good idea want to take a stab at it?
There was a problem hiding this comment.
not sure if this is addressed here #3919
There was a problem hiding this comment.
I'll add this once we merge 3919
* uv sync works * fist stab at Makefile * uv treatment for langflow-base * sqlmodel to 0.0.18 * add reinstall_backend to Makefile * makefile - reinstall_backend fix and unit_test dependency * fix dev dependencies * fix dev dependencies * fix dev dependencies * lock * Makefile * [autofix.ci] apply automated fixes * Update Makefile Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> * delete update_dependencies * fix lint * Remove Poetry lock check from GitHub Actions workflow * Switch to 'uv' for dependency management and caching in style-check workflow * Update style-check workflow to use '--only-dev' flag for Ruff check * Integrate 'uv' package setup and caching in GitHub Actions workflows * Update version check in GitHub Actions to use 'uv tree' for langflow-base * Remove redundant poetry environment setup in GitHub Actions workflow * Add step to minimize uv cache in GitHub Actions workflow * Update GitHub Actions workflow to use 'uv' for dependency management and caching * Remove redundant script execution from build_langflow target in Makefile * [autofix.ci] apply automated fixes * Switch build system from Poetry to Hatchling and update dependencies - Replace `poetry-core` with `hatchling` in build-system requirements - Update `langflow-base` dependency to version `0.0.96` - Add `tool.hatch.build.targets.wheel` configuration - Adjust `tool.uv.sources` paths for `langflow-frontend` and `langflow-base` * update lock * Switch build system from Poetry to Hatchling in pyproject.toml * Add langchain-unstructured dependency to pyproject.toml --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
uvis a relatively new python package manager with great performance. Langflow has a lot of dependencies that result in slowpoetryinstall / lock times which uv can alleviate.This WIP PR gets the core features like build and unit tests working.
Would be great to get nightlies working with
uv.package publish with
uvis pending.The current config supports both
poetryanduv. We can removepoetryas we gain confidence withuv.