Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Handle prompts with no Chat messsages #3892

Merged
merged 1 commit into from
Sep 24, 2024
Merged

bugfix: Handle prompts with no Chat messsages #3892

merged 1 commit into from
Sep 24, 2024

Conversation

erichare
Copy link
Collaborator

This pull request makes two important fixes:

  1. It supports Langchain Hub Templates that don't have messages, but rather just a simple prompt.
  2. It gives a better error message when an API key is not provided.

@erichare
bugfix: Handle prompts with no Chat messsages
d11d05b 
Also require API key  for langsmith
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Sep 23, 2024
ogabrielluiz
ogabrielluiz approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @erichare

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) September 24, 2024 13:51
@ogabrielluiz ogabrielluiz merged commit b59ae6b into langflow-ai:main Sep 24, 2024
43 of 45 checks passed
@erichare erichare deleted the bugfix-langchain-hub branch September 25, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@carlosrcoelho carlosrcoelho Awaiting requested review from carlosrcoelho

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erichare @ogabrielluiz