Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Activate ruff rules UP(pyupgrade) #3871

Merged
merged 6 commits into from
Sep 25, 2024
Merged

feat: Activate ruff rules UP(pyupgrade) #3871

merged 6 commits into from
Sep 25, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 20, 2024

No description provided.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request python Pull requests that update Python code labels Sep 20, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 20, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3871.dmtpw4p5recq1.amplifyapp.com

ogabrielluiz
ogabrielluiz requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @cbornet

Thanks for this. I was looking forward to getting pyupgrade automated.

src/backend/base/langflow/services/tracing/langwatch.py Show resolved Hide resolved
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 24, 2024
@cbornet cbornet force-pushed the ruff-rules-up branch 2 times, most recently from 2099100 to ce19ce5 Compare September 24, 2024 12:00
@cbornet
Copy link
Collaborator Author

cbornet commented Sep 24, 2024

I added from __future__ import annotations and also set the python min version for ruff, allowing more UP rules to be effective.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 24, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) September 25, 2024 17:29
@ogabrielluiz ogabrielluiz merged commit f8a2a7d into langflow-ai:main Sep 25, 2024
30 checks passed
@cbornet cbornet deleted the ruff-rules-up branch September 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz