Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit file upload size to 10mb to prevent LF crashing due data render component limitations #3870

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

Cristhianzl
Copy link
Member

@Cristhianzl Cristhianzl commented Sep 20, 2024

This PR addresses an issue where file uploads larger than 10MB would cause the application to crash due to limitations in the data render component.

*** While this isn't a comprehensive solution, it will prevent Langflow from crashing during use, ensuring a more stable experience for users.

…ading to prevent uploading files larger than the maximum allowed size
… display an alert message when the file size is too large
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 20, 2024
@Cristhianzl Cristhianzl self-assigned this Sep 20, 2024
@dosubot dosubot bot added the bug Something isn't working label Sep 20, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 20, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 20, 2024
…meter from 9 to 10 to match the new file size limit

🐛 (constants/constants.ts): increase maxSizeFilesInBytes constant value from 9MB to 10MB to reflect the new file size limit
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 20, 2024 21:18
@Cristhianzl Cristhianzl changed the title fix: limit file upload size to 9mb to prevent LF crashing due data render component limitations fix: limit file upload size to 10mb to prevent LF crashing due data render component limitations Sep 20, 2024
@Cristhianzl Cristhianzl merged commit aa25783 into main Sep 20, 2024
21 checks passed
@Cristhianzl Cristhianzl deleted the cz/limitFileSize branch September 20, 2024 21:33
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 20, 2024
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…ender component limitations (langflow-ai#3870)

* 🐛 (inputFileComponent/index.tsx): add check for file size before uploading to prevent uploading files larger than the maximum allowed size

* ✨ (alerts_constants.tsx): add new constant INVALID_FILE_SIZE_ALERT to display an alert message when the file size is too large

* ✨ (constants.ts): add constant maxSizeFilesInBytes to define the maximum file size allowed for upload in bytes

* 🐛 (inputFileComponent/index.tsx): update INVALID_FILE_SIZE_ALERT parameter from 9 to 10 to match the new file size limit
🐛 (constants/constants.ts): increase maxSizeFilesInBytes constant value from 9MB to 10MB to reflect the new file size limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants