fix: add check for variable value before calling method #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
github-actions
bot
added
bug
jordanrfrazier
approved these changes
Sep 20, 2024
Short answer: The tracing service will not initialize if the necessary environment variables are not set. Full answer: If tracing is optional, it may not be activated in certain scenarios, such as when the environment variables are not configured. Even though the variable might always be populated, not handling this properly could lead to future issues, allowing the tracing service to fail to initialize as expected.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the variable has a value before invoking its method to prevent potential error.
Fixes #3854