Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image not been sent on ChatInputComponent during runtime of building a flow #3862

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

Cristhianzl
Copy link
Collaborator

#3836

This PR addresses the issue by ensuring that the image is properly sent when using the ChatInputComponent in runtime scenarios. This fix allows the flow to correctly pass the image file for analysis, enabling LLM image processing without errors.

This commit refactors the logic for rewriting file paths in the `rewrite_file_path` function. The function now splits the file path by "/" and checks if it has at least two parts. If it does, it creates a consistent file path by concatenating the last two parts. If not, it returns the original file path. This change improves the consistency of file paths in the codebase.

Refactor the file path rewriting logic in the `rewrite_file_path` function.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working javascript Pull requests that update Javascript code python Pull requests that update Python code labels Sep 19, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 19, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3862.dmtpw4p5recq1.amplifyapp.com

@Cristhianzl Cristhianzl self-assigned this Sep 20, 2024
Cristhianzl and others added 4 commits September 23, 2024 10:31
…re specific about the tool used for sending images on chat

📝 (general-bugs-shard-3836.spec.ts): remove unused import of readFileSync from fs module
…th function to ensure correct behavior with various file path scenarios
… backward slashes and extract file path after drive letter if present
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@Cristhianzl Cristhianzl merged commit ad97ee9 into main Sep 23, 2024
36 of 37 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-img-chatinput-flow branch September 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants