-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: image not been sent on ChatInputComponent during runtime of building a flow #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the logic for rewriting file paths in the `rewrite_file_path` function. The function now splits the file path by "/" and checks if it has at least two parts. If it does, it creates a consistent file path by concatenating the last two parts. If not, it returns the original file path. This change improves the consistency of file paths in the codebase. Refactor the file path rewriting logic in the `rewrite_file_path` function.
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
bug
Something isn't working
javascript
Pull requests that update Javascript code
python
Pull requests that update Python code
labels
Sep 19, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Sep 19, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…re specific about the tool used for sending images on chat 📝 (general-bugs-shard-3836.spec.ts): remove unused import of readFileSync from fs module
…th function to ensure correct behavior with various file path scenarios
… backward slashes and extract file path after drive letter if present
italojohnny
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
python
Pull requests that update Python code
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3836
This PR addresses the issue by ensuring that the image is properly sent when using the ChatInputComponent in runtime scenarios. This fix allows the flow to correctly pass the image file for analysis, enabling LLM image processing without errors.