ci: remove unnecessary ref checkout for nightly tests #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
So with this change the job will consider the current tag (tag from which the job was initiated) as reference right? |
edwinjosechittilappilly
approved these changes
Sep 18, 2024
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
Remove unnecessary ref checkout for nightly tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
refcheckout failed because thelangflow-base-nightlytag was not yet pushed to pypi, but the project dependency has already been updated to point to the new base nightly version from main nightly.I realize that we don't need to checkout out the main tag for testing. The
github.refdefault will point to the same ref that triggered the workflow, so it will test the same code that we are tagging. The only risk is if our scripts actually modify the codebase itself, but that's low-risk and shouldn't happen.