Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix building loop when renaming a folder and opening a new flow and running It #3844

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request addresses an issue where the application enters a build loop after renaming a folder, opening a new flow, and running the flow. The build loop caused unnecessary rebuilds and performance issues when these actions were performed in sequence.

#3823

Refactor the folder sidebar buttons component to improve its structure and readability. This includes adding a new hook for folder fetching, handling rendering and filtering functionality, and updating the UI for adding and uploading folders. The changes also include handling double-click and keydown events for folder items, as well as fixing some bugs related to folder editing and deleting. These improvements enhance the overall user experience and maintainability of the codebase.
@Cristhianzl Cristhianzl self-assigned this Sep 18, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Sep 18, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 18, 2024
@Cristhianzl Cristhianzl requested review from lucaseduoli and anovazzi1 and removed request for anovazzi1 September 18, 2024 13:20
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 18, 2024
@Cristhianzl Cristhianzl merged commit 98c1f0e into main Sep 18, 2024
25 of 26 checks passed
@Cristhianzl Cristhianzl deleted the cz/loopRenameFolder branch September 18, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants