Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integrations category in the sidebar #3843

Merged
merged 17 commits into from
Oct 2, 2024
Merged

Conversation

anovazzi1
Copy link
Contributor

This pull request adds the integration group to the sidebar

@anovazzi1 anovazzi1 marked this pull request as ready for review September 18, 2024 19:58
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 18, 2024
@dosubot dosubot bot added the enhancement New feature or request label Sep 18, 2024
@ogabrielluiz ogabrielluiz changed the title feature: add integrations feat: add integrations category in the sidebar Sep 19, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. size:M This PR changes 30-99 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 1, 2024
anovazzi1 and others added 13 commits October 1, 2024 16:38
This commit adds a new skipFallback parameter to the ForwardedIconComponent in the genericIconComponent module. The skipFallback parameter allows developers to skip rendering the fallback component when using Suspense. This can be useful in cases where the fallback component is not needed or should be handled differently.
…conComponent

This commit adds the skipFallback parameter to the IconComponentProps and ForwardedIconComponent. This parameter allows skipping the fallback icon rendering when the specified icon is not found. The skipFallback parameter is used in the ParentDisclosureComponent to conditionally render the chevron-down or chevron-right icon based on the component's state.

The commit also updates the defaultOpen value in the ParentDisclosureComponent in the ExtraSidebarComponent. The defaultOpen value is set to true, ensuring that the "Integrations" section is always expanded when the component is rendered.
@ogabrielluiz ogabrielluiz merged commit 0d796db into main Oct 2, 2024
28 checks passed
@ogabrielluiz ogabrielluiz deleted the enableIntegrations branch October 2, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants