Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json dark mode colors and dict component button view #3802

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes changes to fix the dark mode colors on the jsonView component and to improve the button view of the dict component. The dark mode colors on the jsonView component have been adjusted to match the desired style. Additionally, the button in the dict component has been updated to include an icon and a label for better clarity. These changes improve the overall user experience and visual consistency of the application.

@lucaseduoli lucaseduoli enabled auto-merge (squash) September 13, 2024 15:15
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 13, 2024
@lucaseduoli lucaseduoli self-assigned this Sep 13, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Sep 13, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 13, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3802.dmtpw4p5recq1.amplifyapp.com

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 13, 2024
@lucaseduoli lucaseduoli merged commit 35c194e into main Sep 13, 2024
35 of 37 checks passed
@lucaseduoli lucaseduoli deleted the fix/json_view_dark branch September 13, 2024 16:34
smatiolids pushed a commit to smatiolids/langflow-dev that referenced this pull request Sep 16, 2024
…i#3802)

* Fix dark mode colors on jsonView

* Fix dict component button view

* Changed style of dict component button

* Changed parameter render to remove space on the bottom of the inputs that are only handles

* Fixed space below nodes
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…i#3802)

* Fix dark mode colors on jsonView

* Fix dict component button view

* Changed style of dict component button

* Changed parameter render to remove space on the bottom of the inputs that are only handles

* Fixed space below nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants