Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JSONViewer component style update to fits on dark and light mode #3792

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

Cristhianzl
Copy link
Collaborator

✨ (frontend): Add react-json-view-lite package to frontend dependencies
📝 (frontend): Update JsonView component in dictAreaModal to use dark theme and adjust class name
📝 (frontend): Update background color for dark theme in JsonView component styling

📝 (frontend): Update JsonView component in dictAreaModal to use dark theme and adjust class name
📝 (frontend): Update background color for dark theme in JsonView component styling
@Cristhianzl Cristhianzl self-assigned this Sep 12, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 12, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Sep 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 12, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 13, 2024 01:23
@Cristhianzl Cristhianzl removed the request for review from anovazzi1 September 13, 2024 01:37
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 13, 2024 01:37
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 13, 2024 13:58
@Cristhianzl Cristhianzl merged commit fc23de6 into main Sep 13, 2024
28 of 31 checks passed
@Cristhianzl Cristhianzl deleted the cz/jsonViewerUpdate branch September 13, 2024 14:38
smatiolids pushed a commit to smatiolids/langflow-dev that referenced this pull request Sep 16, 2024
…langflow-ai#3792)

* ✨ (frontend): Add react-json-view-lite package to frontend dependencies
📝 (frontend): Update JsonView component in dictAreaModal to use dark theme and adjust class name
📝 (frontend): Update background color for dark theme in JsonView component styling

* 🔧 (generalBugs-shard-13.spec.ts): remove unnecessary line causing linting issue

* updating lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants