feat(Weaviate): Enforce capitalized index name #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add get_valid_index_name method to ensure index name is capitalized - Update index_name input with info about capitalization requirement - Implement capitalization check before creating vector store - Remove type ignore comment for weaviate import Ref: https://forum.weaviate.io/t/feature-or-bug-first-letter-of-class-name-gets-capitalized/1203
edwinjosechittilappilly
requested review from
carlosrcoelho and
jordanrfrazier
dosubot
bot
added
size:S
github-actions
bot
added
enhancement
|
closes #3742 |
github-actions
bot
added
enhancement
carlosrcoelho
requested review from
ogabrielluiz and
jordanrfrazier
and removed request for
carlosrcoelho
jordanrfrazier
requested changes
Sep 26, 2024
jordanrfrazier
requested changes
Sep 27, 2024
…-ai/langflow into fix-weaviate-index-name
jordanrfrazier
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://forum.weaviate.io/t/feature-or-bug-first-letter-of-class-name-gets-capitalized/1203