feat: Enhance HuggingFace Embeddings Inference component #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance HuggingFaceInferenceAPIEmbeddings component - Update display name and description for clarity - Add API URL validation method - Implement local URL detection and dummy API key for local deployments - Improve error handling for API key and URL requirements - Update documentation link
edwinjosechittilappilly
requested review from
ogabrielluiz and
jordanrfrazier
dosubot
bot
added
the
size:M
github-actions
bot
added
enhancement
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jordanrfrazier
approved these changes
Sep 12, 2024
src/backend/base/langflow/components/embeddings/HuggingFaceInferenceAPIEmbeddings.py
Outdated
Show resolved
Hide resolved
src/backend/base/langflow/components/embeddings/HuggingFaceInferenceAPIEmbeddings.py
Outdated
Show resolved
Hide resolved
src/backend/base/langflow/components/embeddings/HuggingFaceInferenceAPIEmbeddings.py
Outdated
Show resolved
Hide resolved
src/backend/base/langflow/components/embeddings/HuggingFaceInferenceAPIEmbeddings.py
Outdated
Show resolved
Hide resolved
src/backend/base/langflow/components/embeddings/HuggingFaceInferenceAPIEmbeddings.py
Show resolved
Hide resolved
src/backend/base/langflow/components/embeddings/HuggingFaceInferenceAPIEmbeddings.py
Outdated
Show resolved
Hide resolved
src/backend/base/langflow/components/embeddings/HuggingFaceInferenceAPIEmbeddings.py
Outdated
Show resolved
Hide resolved
- Update base class from LCModelComponent to LCEmbeddingsModel - Rename 'api_url' to 'inference_endpoint' for clarity - Improve error messages and validation for inference endpoint - Update documentation link - Enhance comments and code formatting
|
@jordanrfrazier can you help me out why certain CI Checks are failing ? |
smatiolids
pushed a commit
to smatiolids/langflow-dev
that referenced
this pull request
Sep 16, 2024
…#3758) # Enhance HuggingFaceInferenceAPIEmbeddings component ## Initial enhancements - Update display name and description for clarity - Add API URL validation method - Implement local URL detection and dummy API key for local deployments - Improve error handling for API key and URL requirements - Update documentation link ## API key info update - Updated the info in API key input ## Refactor and improvements - Update base class from LCModelComponent to LCEmbeddingsModel - Rename 'api_url' to 'inference_endpoint' for clarity - Improve error messages and validation for inference endpoint - Update documentation link - Enhance comments and code formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the HuggingFaceInferenceAPIEmbeddings component to improve its functionality, error handling, and support for local/remote inference deployments.
Key Changes
Benefits
Testing
Screen.Recording.2024-09-10.at.9.31.47.PM.mov