Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: url component output types and id generator component #3740

Merged
merged 9 commits into from
Sep 10, 2024
Merged

fix: url component output types and id generator component #3740

merged 9 commits into from
Sep 10, 2024

Conversation

lucaseduoli
Copy link
Collaborator

Added a text output as a Message to URL Component to make data fetching easier

@lucaseduoli lucaseduoli self-assigned this Sep 9, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 9, 2024 21:07
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 9, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 9, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3740.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 9, 2024
@lucaseduoli lucaseduoli changed the title fix: url component output types fix: url component output types and id generator component Sep 9, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 9, 2024
anovazzi1
anovazzi1 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 9, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 10, 2024 12:02
@lucaseduoli lucaseduoli merged commit 0088b46 into main Sep 10, 2024
30 checks passed
@lucaseduoli lucaseduoli deleted the improve/url_component branch September 10, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anovazzi1 anovazzi1 anovazzi1 approved these changes

Assignees

@lucaseduoli lucaseduoli

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaseduoli @anovazzi1