Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: textarea with password visual bug #3739

Merged
merged 12 commits into from
Sep 10, 2024
Merged

fix: textarea with password visual bug #3739

merged 12 commits into from
Sep 10, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request fixes a visual bug in the textarea component where the password field was not displaying correctly. The password field has been changed to default to none, resolving the issue.

Update sanitizedHTMLWrapper to receive ref

This pull request updates the sanitizedHTMLWrapper component to receive a ref. This allows for better control and manipulation of the component's behavior.

Add back to scroll position and cursor position on Chrome

@lucaseduoli lucaseduoli self-assigned this Sep 9, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 9, 2024 20:53
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working enhancement New feature or request javascript Pull requests that update Javascript code labels Sep 9, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request bug Something isn't working labels Sep 9, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3739.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image visual bug

@anovazzi1 anovazzi1 self-requested a review September 9, 2024 23:29
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 9, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder incripted:
image
image

@anovazzi1 anovazzi1 self-requested a review September 10, 2024 16:13
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problems that were reported were on main before this pull request and will be fixed in other pr

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@lucaseduoli lucaseduoli merged commit 5bb266c into main Sep 10, 2024
30 checks passed
@lucaseduoli lucaseduoli deleted the prompt_visual_bugs branch September 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants