-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YahooFinanceTool): enhance tool with new inputs for data retrieval methods #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
enhancement
New feature or request
labels
Sep 9, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Sep 9, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
italojohnny
approved these changes
Sep 9, 2024
ogabrielluiz
requested changes
Sep 19, 2024
@@ -14,7 +14,7 @@ def complex_agent_graph(): | |||
llm = OpenAIModelComponent(model_name="gpt-4o-mini") | |||
manager_llm = OpenAIModelComponent(model_name="gpt-4o") | |||
search_api_tool = SearchAPIComponent() | |||
yahoo_search_tool = YfinanceToolComponent() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this instantiation is required. I'm not sure why it was removed
ogabrielluiz
force-pushed
the
fix-yf-tool
branch
from
October 2, 2024 20:25
9d44d89
to
4e238de
Compare
ogabrielluiz
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored YF Tool to use the lib directly, rather than langchain's broken implementation. more features were added too.