Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node status display when node minimized #3737

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

This pull request removes unused code and fixes an issue where the node status was still being displayed when the node was minimized. It also fixes a bug where the node wouldn't expand after being minimized if an output was hidden. Additionally, some linting has been done to improve code quality.

@lucaseduoli lucaseduoli self-assigned this Sep 9, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 9, 2024 19:44
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working javascript Pull requests that update Javascript code labels Sep 9, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 9, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3737.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 9, 2024
@lucaseduoli lucaseduoli merged commit f706554 into main Sep 9, 2024
26 of 27 checks passed
@lucaseduoli lucaseduoli deleted the fix/overlaying_build branch September 9, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants