Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable add new folder button when isLoading #3734

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

Cristhianzl
Copy link
Collaborator

✨ (index.tsx): Add ShadTooltip component to provide tooltips for folder buttons for better user experience
📝 (index.tsx): Import useIsFetching from "@tanstack/react-query" to check if there are ongoing data fetching operations before enabling folder buttons

…er buttons for better user experience

📝 (index.tsx): Import useIsFetching from "@tanstack/react-query" to check if there are ongoing data fetching operations before enabling folder buttons
@Cristhianzl Cristhianzl self-assigned this Sep 9, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Sep 9, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Sep 9, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3734.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image if i click fast i can send multiple request at once

… loading state for adding folders

🔧 (index.tsx): update disabled attribute in add and upload folder buttons to include isPending variable to prevent multiple submissions
@anovazzi1 anovazzi1 self-requested a review September 10, 2024 19:36
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) September 10, 2024 19:43
@anovazzi1 anovazzi1 merged commit af99b4c into main Sep 10, 2024
21 checks passed
@anovazzi1 anovazzi1 deleted the cz/disable_btn_save_folder branch September 10, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants