feat: Enhance Data Components and Add SelectData Functionality #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: Text Key name check validation , throws and error if its not a valid key Updated the Update Data Component to be update and append data. With this update multiple data can be updated or appended to the old created data. Also There is an option to update the text key, in update/ append Data
This functionality is added to turn on or off the text key validator if the data is Dynamically loaded from another source and the user doesn't want to validate the text_key
edwinjosechittilappilly
requested review from
ogabrielluiz and
jordanrfrazier
dosubot
bot
added
the
size:L
github-actions
bot
added
bug
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
refactor: Remove legacy post_code_processing methods - Remove post_code_processing methods from CreateDataComponent and UpdateDataComponent - These methods were duplicating functionality already present in the parent class - Remove corresponding test case for post_code_processing in CreateDataComponent and UpdateDataComponent
|
@jordanrfrazier Can you review these changes ? I have removed the legacy codes. |
src/backend/tests/unit/components/prototypes/test_createData_component.py
Outdated
Show resolved
Hide resolved
jordanrfrazier
approved these changes
Sep 13, 2024
Add SelectDataComponent to handle data selection from a list - Create new SelectDataComponent class - Implement inputs for data list and index selection - Ensure proper error handling for out-of-range index selection
|
@jordanrfrazier I have created Select Data component to solve some issues of update data component. can you review it once. |
edwinjosechittilappilly
changed the title
|
@jordanrfrazier Once available can you also look why the CI fails, hence not able to merge it with main. |
| def validate_text_key(self): | ||
| """This function validates that the Text Key is one of the keys in the Data""" | ||
| data_keys = self.get_data().keys() | ||
| if self.text_key not in data_keys and self.text_key != "": |
There was a problem hiding this comment.
should we raise another error is the self.text_key is an empty string?
|
|
||
| class SelectDataComponent(Component): | ||
| display_name: str = "Select Data" | ||
| description: str = "Select a single data from a list of data." |
There was a problem hiding this comment.
Hm, I'm not sure what it means to select a single data from a list of data. Is it selecting a row, a column, a field? Can we be more user-friendly with this description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Data Component:
Update/Append Data Component:
Text Key Validator:
text_key_validatorto allow users to disable key validation when data is dynamically sourced, and key validation is not necessary.Fixes:
closes #3644