Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add x-large size option to baseModal and various modals resizes #3710

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request adds a new size option "x-large" to the baseModal component.

The "x-large" size option sets the minimum width to "min-w-[95vw]" and the height to "h-[95vh]".
This change allows for a larger modal size when needed. The code changes include updates to the baseModal component, CodeAreaModal, EditNodeModal, FlowLogsModal, PromptModal, and ComponentTextModal to use the new "x-large" size option.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 6, 2024
@dosubot dosubot bot added the enhancement New feature or request label Sep 6, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 6, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3710.dmtpw4p5recq1.amplifyapp.com

@anovazzi1 anovazzi1 requested review from rodrigosnader and anovazzi1 and removed request for anovazzi1 September 6, 2024 16:38
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 6, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 6, 2024 18:16
@Cristhianzl Cristhianzl merged commit f72e009 into main Sep 6, 2024
21 checks passed
@Cristhianzl Cristhianzl deleted the cz/ux-playground-modalSize branch September 6, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants