-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add x-large size option to baseModal and various modals resizes #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code changes introduce a new size option "x-large" to the baseModal component. This size option sets the minimum width to "min-w-[95vw]" and the height to "h-[95vh]". This change allows for a larger modal size when needed.
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Sep 6, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Sep 6, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
anovazzi1
requested review from
rodrigosnader and
anovazzi1
and removed request for
anovazzi1
September 6, 2024 16:38
anovazzi1
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ity and maintainability. Fix the order of properties in CSS classes to follow a consistent pattern.
…low-ai/langflow into cz/ux-playground-modalSize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new size option "x-large" to the baseModal component.
The "x-large" size option sets the minimum width to "min-w-[95vw]" and the height to "h-[95vh]".
This change allows for a larger modal size when needed. The code changes include updates to the baseModal component, CodeAreaModal, EditNodeModal, FlowLogsModal, PromptModal, and ComponentTextModal to use the new "x-large" size option.