-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stop button on Playground Chat #3704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constants for better readability and maintainability 🐛 (buttonSendWrapper/index.tsx): fix logic to disable button when chat is locked and not building 🐛 (buttonSendWrapper/index.tsx): fix conditional rendering of icons based on button state
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
bug
Something isn't working
labels
Sep 5, 2024
github-actions
bot
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Sep 5, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…building from inside Playground.
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Sep 5, 2024
…tly prioritize showStopButton condition and improve code readability
…stopped" text is visible after clicking on the stop button
…tion to getButtonState for better clarity and consistency in naming 🐛 (buttonSendWrapper/index.tsx): fix logic in handleClick function to properly handle the conditions for sending messages and stopping building process
…w-ai/langflow into cz/ux-playground-stopbtn
Cristhianzl
requested review from
anovazzi1
and removed request for
anovazzi1
September 5, 2024 21:46
lucaseduoli
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…w-ai/langflow into cz/ux-playground-stopbtn
…ser agent information for conditional logic based on operating system 📝 (stop-button-playground.spec.ts): update comments and documentation for better code readability and understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the button styling logic in
buttonSendWrapper/index.tsx
to use constants for better readability and maintainability.Additionally, fixed the logic to disable the button when the chat is locked and not building, and also fixed the conditional rendering of icons based on the button state.
This pull request improves the code structure and ensures correct button behavior in the chat input component.
🐛 (buttonSendWrapper/index.tsx): fix logic to disable button when chat is locked and not building
🐛 (buttonSendWrapper/index.tsx): fix conditional rendering of icons based on button state
📝 (buttonSendWrapper/index.tsx): refactor button styling logic to use constants for better readability and maintainability