Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stop button on Playground Chat #3704

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Conversation

Cristhianzl
Copy link
Collaborator

Refactored the button styling logic in buttonSendWrapper/index.tsx to use constants for better readability and maintainability.

Additionally, fixed the logic to disable the button when the chat is locked and not building, and also fixed the conditional rendering of icons based on the button state.

This pull request improves the code structure and ensures correct button behavior in the chat input component.

🐛 (buttonSendWrapper/index.tsx): fix logic to disable button when chat is locked and not building
🐛 (buttonSendWrapper/index.tsx): fix conditional rendering of icons based on button state
📝 (buttonSendWrapper/index.tsx): refactor button styling logic to use constants for better readability and maintainability

… constants for better readability and maintainability

🐛 (buttonSendWrapper/index.tsx): fix logic to disable button when chat is locked and not building
🐛 (buttonSendWrapper/index.tsx): fix conditional rendering of icons based on button state
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Sep 5, 2024
@github-actions github-actions bot added enhancement New feature or request and removed bug Something isn't working labels Sep 5, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3704.dmtpw4p5recq1.amplifyapp.com

lucaseduoli

This comment was marked as resolved.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 5, 2024
…tly prioritize showStopButton condition and improve code readability
…stopped" text is visible after clicking on the stop button
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 5, 2024 21:35
…tion to getButtonState for better clarity and consistency in naming

🐛 (buttonSendWrapper/index.tsx): fix logic in handleClick function to properly handle the conditions for sending messages and stopping building process
@Cristhianzl Cristhianzl requested review from anovazzi1 and removed request for anovazzi1 September 5, 2024 21:46
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
…ser agent information for conditional logic based on operating system

📝 (stop-button-playground.spec.ts): update comments and documentation for better code readability and understanding
@Cristhianzl Cristhianzl merged commit 9b83f44 into main Sep 6, 2024
28 checks passed
@Cristhianzl Cristhianzl deleted the cz/ux-playground-stopbtn branch September 6, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants