Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove saving on flow pan and add fit view to reactflow #3696

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

lucaseduoli
Copy link
Collaborator

I have made the following changes:

  • Removed the viewport setting on resetFlow and setReactflowInstance functions.

  • Removed the onMoveEnd function and its usage.

  • Added the fitView prop to the ReactFlow component to make it start with a fit view.

These changes ensure that the ReactFlow canvas starts with a fit view, providing a better initial visualization of the flow.

@lucaseduoli lucaseduoli self-assigned this Sep 5, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) September 5, 2024 13:57
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Sep 5, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Sep 5, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3696.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
@lucaseduoli lucaseduoli merged commit c31005a into main Sep 5, 2024
20 checks passed
@lucaseduoli lucaseduoli deleted the fix/save_on_pan branch September 5, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants