fix: getall is being called unnecessarily every time the user accesses the My Collection page #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re empty before calling getTypes to avoid unnecessary API calls ♻️ (typesStore.ts): Remove unnecessary useAlertStore setState call to improve code readability and maintainability
dosubot
bot
added
size:XS
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Cristhianzl
changed the title
github-actions
bot
added
bug
|
We still have other places that we call getTypes. Can you check them out too? |
The `getTypes` function in `typesStore.ts` has been updated to always force a refresh of the types data. This change ensures that the latest data is fetched from the API, avoiding unnecessary API calls.
yes, there's just another place, but Its already true |
dosubot
bot
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the /getall endpoint was being called unnecessarily every time a user accessed the 'My Collection' page. This redundant API call could lead to increased load times and unnecessary server strain.
✨ (use-get-folders.ts): Update useGetFoldersQuery to check if types are empty before calling getTypes to avoid unnecessary API calls
♻️ (typesStore.ts): Remove unnecessary useAlertStore setState call to improve code readability and maintainability