Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: success dialog popping wrong #3659

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix: success dialog popping wrong #3659

merged 3 commits into from
Sep 2, 2024

Conversation

Cristhianzl
Copy link
Collaborator

🐛 (sideBarFolderButtons/index.tsx): fix success message not being set when files array is empty

@Cristhianzl Cristhianzl self-assigned this Sep 2, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Sep 2, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 2, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3659.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if the files are empty before trying to call uploadFlow

@Cristhianzl Cristhianzl requested review from lucaseduoli and ogabrielluiz and removed request for anovazzi1 September 2, 2024 20:46
@Cristhianzl
Copy link
Collaborator Author

Check if the files are empty before trying to call uploadFlow

yep, u are right

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 2, 2024 20:57
@Cristhianzl Cristhianzl removed the request for review from ogabrielluiz September 2, 2024 21:05
@Cristhianzl Cristhianzl merged commit 70af48c into main Sep 2, 2024
27 of 28 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-upload-msg branch September 2, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants