Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Self Query Retriever Component #3653

Merged
merged 5 commits into from
Sep 2, 2024
Merged

fix: update Self Query Retriever Component #3653

merged 5 commits into from
Sep 2, 2024

Conversation

Cristhianzl
Copy link
Collaborator

🔧 (pyproject.toml): add lark dependency to support parsing and processing of grammars in the project
♻️ (SelfQueryRetriever.py): refactor input types in metadata fields to improve clarity and maintainability

…sing of grammars in the project

♻️ (SelfQueryRetriever.py): refactor input types in metadata fields to improve clarity and maintainability
@Cristhianzl Cristhianzl self-assigned this Sep 2, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. python Pull requests that update Python code labels Sep 2, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Detected 1 changes to dependencies in Poetry lockfile

Added lark (1.2.2)

(1 added, 0 removed, 0 updated, 474 not changed)

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3653.dmtpw4p5recq1.amplifyapp.com

…ncy and clarity

📝 (SelfQueryRetriever.py): Refactor input and output definitions for better readability and maintainability
📝 (SelfQueryRetriever.py): Refactor method signatures and variable names for improved code organization and understanding
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 2, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) September 2, 2024 20:17
@Cristhianzl Cristhianzl merged commit 706d559 into main Sep 2, 2024
36 of 37 checks passed
@Cristhianzl Cristhianzl deleted the cz/selfQuery branch September 2, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants