Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop building with abort controller #3634

Merged
merged 4 commits into from
Sep 2, 2024
Merged

fix: stop building with abort controller #3634

merged 4 commits into from
Sep 2, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request adds the buildController and stopBuilding controllers to the codebase. The stopBuilding controller is used in the header's Stop button, and the buildController is set in the API performStreamingRequest function. Additionally, the setBuildController function is added to the types. These changes enhance the control and management of the build process in the application.

@lucaseduoli lucaseduoli self-assigned this Aug 30, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) August 30, 2024 17:41
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Aug 30, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Aug 30, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3634.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 30, 2024
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucaseduoli lucaseduoli merged commit 882c35e into main Sep 2, 2024
20 checks passed
@lucaseduoli lucaseduoli deleted the fix/stop_button branch September 2, 2024 13:36
carlosrcoelho pushed a commit that referenced this pull request Sep 2, 2024
* Added buildController and stopBuilding controllers

* Used stop building in header Stop button

* Set the build controller in API performstreamingrequest

* added setbuildcontroller to types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants