-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: auto login and logout functionality #3629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing only if its authenticated
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
bug
Something isn't working
labels
Aug 30, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Cristhianzl
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Aug 30, 2024
carlosrcoelho
pushed a commit
that referenced
this pull request
Sep 2, 2024
* Made auto login not call refresh * Fixed mutation query * Removed navigation to login on logout function * Made refresh token set cookie for docker * Added return to login with custom navigate and added check for refreshing only if its authenticated * Minor refactor * Navigate after logout on get autologin * Removed unused console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this pull request address issues with the auto login and logout functionality. The changes include fixing the auto login to not call refresh, fixing a mutation query, removing navigation to login on the logout function, setting the refresh token as a cookie for Docker, adding a return to login with custom navigate, and removing unused console.log statements. These changes ensure that the auto login and logout functions work correctly and improve the overall user experience.