Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto login and logout functionality #3629

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Conversation

lucaseduoli
Copy link
Collaborator

The commits in this pull request address issues with the auto login and logout functionality. The changes include fixing the auto login to not call refresh, fixing a mutation query, removing navigation to login on the logout function, setting the refresh token as a cookie for Docker, adding a return to login with custom navigate, and removing unused console.log statements. These changes ensure that the auto login and logout functions work correctly and improve the overall user experience.

@lucaseduoli lucaseduoli self-assigned this Aug 30, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Aug 30, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3629.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 30, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 30, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) August 30, 2024 18:11
@lucaseduoli lucaseduoli merged commit a71375c into main Aug 30, 2024
21 checks passed
@lucaseduoli lucaseduoli deleted the fix/refresh_token branch August 30, 2024 18:19
carlosrcoelho pushed a commit that referenced this pull request Sep 2, 2024
* Made auto login not call refresh

* Fixed mutation query

* Removed navigation to login on logout function

* Made refresh token set cookie for docker

* Added return to login with custom navigate and added check for refreshing only if its authenticated

* Minor refactor

* Navigate after logout on get autologin

* Removed unused console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants