Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix type comparison issues in codebase #3606

Merged
merged 3 commits into from
Aug 29, 2024
Merged

style: Fix type comparison issues in codebase #3606

merged 3 commits into from
Aug 29, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request fixes type comparison issues in the codebase. The changes ensure that type comparisons are done correctly using the is operator instead of the == operator. This improves the accuracy and reliability of the code.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 28, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 28 Aug 24 21:11 UTC

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 28, 2024 21:12
@github-actions github-actions bot added the style Maintenance tasks and housekeeping label Aug 28, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 28, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3606.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz merged commit e7a48d5 into main Aug 29, 2024
28 checks passed
@ogabrielluiz ogabrielluiz deleted the ruff/fix branch August 29, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. style Maintenance tasks and housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants