refactor: queries loading order and wrapper order #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 28 Aug 24 19:06 UTC |
…efore loading the router
… drop to improve test suite cleanliness and maintainability.
…tionality 🔧 (auto-save-off.spec.ts): add click event for "Save And Exit" button 🔧 (dragAndDrop.spec.ts): change dispatchEvent to getByTestId and add assertions for specific text visibility 🔧 (store-shard-3.spec.ts): increase timeout for page.waitForTimeout to improve test reliability
The code changes include adding the functionality for the replace button on the main page. This allows users to replace a flow or a component. The replace button is now visible on the page, and clicking on it triggers the appropriate action. Recent user commits: - test: improve timeout for page.waitForSelector in auto-save-off.spec.ts - ✅ (folders.spec.ts): update test description to be more descriptive and accurate - ✨ (folders.spec.ts): add test for adding folder by drag and drop functionality - 🔧 (auto-save-off.spec.ts): add click event for "Save And Exit" button - 🔧 (dragAndDrop.spec.ts): change dispatchEvent to getByTestId and add assertions for specific text visibility - 🔧 (store-shard-3.spec.ts): increase timeout for page.waitForTimeout to improve test reliability Recent repository commits: - test: improve timeout for page.waitForSelector in auto-save-off.spec.ts - ✅ (folders.spec.ts): update test description to be more descriptive and accurate - ✨ (folders.spec.ts): add test for adding folder by drag and drop functionality - 🔧 (auto-save-off.spec.ts): add click event for "Save And Exit" button - 🔧 (dragAndDrop.spec.ts): change dispatchEvent to getByTestId and add assertions for specific text visibility - 🔧 (store-shard-3.spec.ts): increase timeout for page.waitForTimeout to improve test reliability - Fixed flow dropping to another folder - 📝 (folders.spec.ts): remove unused test for adding folder by drag and drop to improve test suite cleanliness and maintainability. - Made loading only exist in one place - Fixed order of wrappers in order for Auth and API context to have access to router - Made ProtectedRoute refresh on authentication change - Updated App.tsx with new gets and configurations and added a loader before loading the router - Updated other queries with the new useQueryFunctionType type
ogabrielluiz
force-pushed
the
refactor/loading_order
branch
from
8ea3e70
to
70975e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several commits that refactor various components in the codebase. The
ComponentsComponentandheaderTabsComponenthave been refactored to receive information from their parent components. TheMyCollectionComponentnow loads folders. Theget configAPI call has been updated to update everything. TheApp.tsxfile has been updated with new gets and configurations, and a loader has been added before loading the router. Additionally, a loading page has been added.