Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update Makefile commands for improved readability and efficiency #3596

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request refactors the Makefile commands to improve readability and efficiency. The changes include redirecting the output of certain commands to /dev/null to reduce noise, updating the build_frontend target to include copying built files to the backend directory for deployment, and refactoring the lint target to depend on the install_backend task for better dependency management. Additionally, the Makefile commands have been updated to use the "@" symbol to suppress command output and improve readability. Finally, a command to delete empty directories has been added to the clean_python_cache target.

…' commands to /dev/null to reduce noise

chore(Makefile): redirect output of 'npm run build' command to /dev/null to improve build process efficiency
feat(Makefile): update build_frontend target to include copying built files to backend directory for deployment
…sk for better dependency management

chore(Makefile): refactor frontend, frontendc, backend, build_and_run, build_and_install, and build targets to depend on setup_env task for consistent environment setup before execution
…lation and frontend build steps for better clarity and consistency
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 28, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 28 Aug 24 13:58 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 28, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3596.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 28, 2024
@ogabrielluiz ogabrielluiz merged commit 5d81e8d into main Aug 28, 2024
17 of 18 checks passed
@ogabrielluiz ogabrielluiz deleted the chore/makelint branch August 28, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants