Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building vertices not working on Safari and improve stop button #3569

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

nicoloboschi
Copy link
Contributor

@nicoloboschi nicoloboschi commented Aug 27, 2024

This PR addresses two problems:

  1. the current client implementation to read chunks from the response using Fetch API is not standard and not compatible with Safari (and probably others). The right way is to use body.getReader() which has much larger support
  2. The Stop button stops the build but it appears to not be working since no feedback is given to users

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 27, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 27, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 27 Aug 24 11:17 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 27, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3569.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 27, 2024
@nicoloboschi nicoloboschi changed the title fix: building vertices not working on Safari fix: building vertices not working on Safari and improve stop button Aug 27, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2024
@ogabrielluiz ogabrielluiz merged commit 8e9ba9c into langflow-ai:main Aug 27, 2024
28 of 29 checks passed
@ogabrielluiz ogabrielluiz mentioned this pull request Aug 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants