Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve file name generation in upload_file function to prevent files with the same name #3550

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

anovazzi1
Copy link
Contributor

@anovazzi1 anovazzi1 commented Aug 26, 2024

The file name generation in the upload_file function has been improved to prevent files with the same name. Previously, the function used the received file name, but now it also includes the file extension. This ensures that each file has a unique name.
fix #3400

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 26, 2024
@anovazzi1 anovazzi1 requested a review from ogabrielluiz August 26, 2024 15:34
@dosubot dosubot bot added the enhancement New feature or request label Aug 26, 2024
@anovazzi1 anovazzi1 changed the title Improve file name generation in upload_file function fix: improve file name generation in upload_file function to prevent files with the same name Aug 26, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 26 Aug 24 15:35 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3550.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 26, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 26, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) August 26, 2024 17:44
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Aug 26, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 26, 2024
@anovazzi1 anovazzi1 merged commit 9bf72ab into main Aug 26, 2024
28 checks passed
@anovazzi1 anovazzi1 deleted the fix/duplicatedImages branch August 26, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different images with the same name generates wrong preview on chat
2 participants