-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Glean Search API Component #3532
feat: Add Glean Search API Component #3532
Conversation
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped. Last Modified at 23 Aug 24 17:58 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
StrInput(name="query", display_name="Query", required=True), | ||
IntInput(name="page_size", display_name="Page Size", value=10), | ||
StrInput(name="field_name", display_name="Field Name", required=False), | ||
NestedDictInput(name="values", display_name="Values", required=False), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe is_list=True
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicoloboschi for this, i ended up changing it to take a NestedDictInput for the full request options body - there are a ton of options and it sounds like some people want them exposed... i'd love to do something elegant with is_list etc but because there's so many more options, i figured this will keep it general but also clean up the UI just slightly....
This pull requests adds a Tool component for the Glean Search API