Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Glean Search API Component #3532

Merged
merged 13 commits into from
Aug 28, 2024

Conversation

erichare
Copy link
Collaborator

This pull requests adds a Tool component for the Glean Search API

Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

Last Modified at 23 Aug 24 17:58 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3532.dmtpw4p5recq1.amplifyapp.com

@erichare erichare marked this pull request as ready for review August 26, 2024 16:32
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request python Pull requests that update Python code labels Aug 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 26, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 26, 2024
StrInput(name="query", display_name="Query", required=True),
IntInput(name="page_size", display_name="Page Size", value=10),
StrInput(name="field_name", display_name="Field Name", required=False),
NestedDictInput(name="values", display_name="Values", required=False),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe is_list=True?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoloboschi for this, i ended up changing it to take a NestedDictInput for the full request options body - there are a ton of options and it sounds like some people want them exposed... i'd love to do something elegant with is_list etc but because there's so many more options, i figured this will keep it general but also clean up the UI just slightly....

@ogabrielluiz ogabrielluiz changed the title Add Glean Search API Component feat: Add Glean Search API Component Aug 28, 2024
@ogabrielluiz ogabrielluiz merged commit 28c9414 into langflow-ai:main Aug 28, 2024
29 checks passed
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 28, 2024
@erichare erichare deleted the feat/glean-component branch October 22, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants