Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if variable is valid before converting #3514

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 22, 2024

Small improvement for better maintainability

Import logging and session modules for better error handling and database interaction in endpoints.py.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Aug 22, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body

Last Modified at 22 Aug 24 20:54 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3514.dmtpw4p5recq1.amplifyapp.com

Add a new function `parse_value` to `utils.py` that parses values based on the input type provided. The function handles different input types such as 'IntInput' and 'FloatInput' to ensure proper parsing.
…unction

Use parse_value utility function to handle different input types and empty values in custom_component_update() for better readability and maintainability.
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 22, 2024 20:59
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024
@ogabrielluiz ogabrielluiz merged commit 4e15090 into main Aug 22, 2024
34 of 35 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-check-if-variable-is-valid-before-converting branch August 22, 2024 21:27
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
* feat: Add logging and session imports to endpoints.py

Import logging and session modules for better error handling and database interaction in endpoints.py.

* refactor: Improve custom component parameter handling in update endpoint

* feat: Add parse_value function to parse values based on input type

Add a new function `parse_value` to `utils.py` that parses values based on the input type provided. The function handles different input types such as 'IntInput' and 'FloatInput' to ensure proper parsing.

* feat: Refactor custom_component_update() to use parse_value utility function

Use parse_value utility function to handle different input types and empty values in custom_component_update() for better readability and maintainability.
ogabrielluiz added a commit that referenced this pull request Aug 27, 2024
* feat: Add logging and session imports to endpoints.py

Import logging and session modules for better error handling and database interaction in endpoints.py.

* refactor: Improve custom component parameter handling in update endpoint

* feat: Add parse_value function to parse values based on input type

Add a new function `parse_value` to `utils.py` that parses values based on the input type provided. The function handles different input types such as 'IntInput' and 'FloatInput' to ensure proper parsing.

* feat: Refactor custom_component_update() to use parse_value utility function

Use parse_value utility function to handle different input types and empty values in custom_component_update() for better readability and maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants