-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if variable is valid before converting #3514
Merged
ogabrielluiz
merged 5 commits into
main
from
fix-check-if-variable-is-valid-before-converting
Aug 22, 2024
Merged
fix: check if variable is valid before converting #3514
ogabrielluiz
merged 5 commits into
main
from
fix-check-if-variable-is-valid-before-converting
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import logging and session modules for better error handling and database interaction in endpoints.py.
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
bug
Something isn't working
labels
Aug 22, 2024
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request is invalid. Reason
Last Modified at 22 Aug 24 20:54 UTC |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Add a new function `parse_value` to `utils.py` that parses values based on the input type provided. The function handles different input types such as 'IntInput' and 'FloatInput' to ensure proper parsing.
…unction Use parse_value utility function to handle different input types and empty values in custom_component_update() for better readability and maintainability.
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Aug 22, 2024
italojohnny
approved these changes
Aug 22, 2024
ogabrielluiz
deleted the
fix-check-if-variable-is-valid-before-converting
branch
August 22, 2024 21:27
This was referenced Aug 26, 2024
anovazzi1
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat: Add logging and session imports to endpoints.py Import logging and session modules for better error handling and database interaction in endpoints.py. * refactor: Improve custom component parameter handling in update endpoint * feat: Add parse_value function to parse values based on input type Add a new function `parse_value` to `utils.py` that parses values based on the input type provided. The function handles different input types such as 'IntInput' and 'FloatInput' to ensure proper parsing. * feat: Refactor custom_component_update() to use parse_value utility function Use parse_value utility function to handle different input types and empty values in custom_component_update() for better readability and maintainability.
ogabrielluiz
added a commit
that referenced
this pull request
Aug 27, 2024
* feat: Add logging and session imports to endpoints.py Import logging and session modules for better error handling and database interaction in endpoints.py. * refactor: Improve custom component parameter handling in update endpoint * feat: Add parse_value function to parse values based on input type Add a new function `parse_value` to `utils.py` that parses values based on the input type provided. The function handles different input types such as 'IntInput' and 'FloatInput' to ensure proper parsing. * feat: Refactor custom_component_update() to use parse_value utility function Use parse_value utility function to handle different input types and empty values in custom_component_update() for better readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement for better maintainability