Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: handle rendering and filtering functionality #3512

Merged
merged 57 commits into from
Sep 13, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request refactors the handle rendering and filtering functionality in the codebase. It includes several commits that make changes to the store, handle rendering components, and node input/output fields. The changes ensure that the handles are always centered, modularize conditions, and centralize the handle without arbitrary values. Additionally, the code now supports connecting on click and shows only the type in the handle tooltip component. This refactoring improves the overall code structure and enhances the user experience when interacting with handles.

@lucaseduoli lucaseduoli self-assigned this Aug 22, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request matches with one (or more) enabled whitelist criteria. Pull request validation is skipped.

Last Modified at 22 Aug 24 19:13 UTC

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 22, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3512.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli marked this pull request as ready for review September 13, 2024 17:44
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 13, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Sep 13, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 13, 2024
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 13, 2024
@lucaseduoli lucaseduoli merged commit 2f1f180 into main Sep 13, 2024
28 checks passed
@lucaseduoli lucaseduoli deleted the feat/handle_refactor branch September 13, 2024 20:27
smatiolids pushed a commit to smatiolids/langflow-dev that referenced this pull request Sep 16, 2024
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants