Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix dropdown components test #3504

Merged
merged 3 commits into from
Aug 22, 2024
Merged

tests: fix dropdown components test #3504

merged 3 commits into from
Aug 22, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request fixes the Dropdown Component test, which broke due to recent updates to the component.

The tests have been updated accordingly.

…onent to improve test coverage and ensure functionality

🔧 (dropdownComponent.spec.ts): update test case to include additional interactions with the page to simulate user behavior and improve test robustness
…800 to improve test reliability

📝 (dropdownComponent.spec.ts): add additional wait time to ensure stability in test execution
@Cristhianzl Cristhianzl self-assigned this Aug 22, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 22, 2024
@dosubot dosubot bot added the bug Something isn't working label Aug 22, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 22 Aug 24 13:25 UTC

@Cristhianzl Cristhianzl enabled auto-merge (squash) August 22, 2024 13:27
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3504.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024
…ering and scrolling in the dropdown component test to improve test readability and maintainability
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 22, 2024
@Cristhianzl Cristhianzl disabled auto-merge August 22, 2024 14:04
@Cristhianzl Cristhianzl enabled auto-merge (squash) August 22, 2024 14:04
@ogabrielluiz ogabrielluiz disabled auto-merge August 22, 2024 14:10
@ogabrielluiz ogabrielluiz merged commit b5116e6 into main Aug 22, 2024
4 of 11 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fix_dropdowntest branch August 22, 2024 14:10
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
* ✅ (dropdownComponent.spec.ts): add missing test case for dropdownComponent to improve test coverage and ensure functionality
🔧 (dropdownComponent.spec.ts): update test case to include additional interactions with the page to simulate user behavior and improve test robustness

* ✅ (dropdownComponent.spec.ts): update mouse wheel scroll distance to 800 to improve test reliability
📝 (dropdownComponent.spec.ts): add additional wait time to ensure stability in test execution

* 🔧 (dropdownComponent.spec.ts): remove unnecessary code related to hovering and scrolling in the dropdown component test to improve test readability and maintainability
ogabrielluiz pushed a commit that referenced this pull request Aug 27, 2024
* ✅ (dropdownComponent.spec.ts): add missing test case for dropdownComponent to improve test coverage and ensure functionality
🔧 (dropdownComponent.spec.ts): update test case to include additional interactions with the page to simulate user behavior and improve test robustness

* ✅ (dropdownComponent.spec.ts): update mouse wheel scroll distance to 800 to improve test reliability
📝 (dropdownComponent.spec.ts): add additional wait time to ensure stability in test execution

* 🔧 (dropdownComponent.spec.ts): remove unnecessary code related to hovering and scrolling in the dropdown component test to improve test readability and maintainability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants