Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add fixtures for client in test files to speed them up #3490

Merged

Conversation

ogabrielluiz
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 22, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body

Last Modified at 22 Aug 24 01:37 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3490.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024
@ogabrielluiz ogabrielluiz changed the title refactor: Add fixtures for client in test files to speed them up refactor: add fixtures for client in test files to speed them up Aug 22, 2024
@ogabrielluiz ogabrielluiz force-pushed the tests-add-client-fixture-override-to-speed-up-tests branch from 63097c8 to 1551feb Compare August 22, 2024 18:50
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 22, 2024
@ogabrielluiz ogabrielluiz merged commit 6d048b2 into main Aug 22, 2024
28 checks passed
@ogabrielluiz ogabrielluiz deleted the tests-add-client-fixture-override-to-speed-up-tests branch August 22, 2024 19:08
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
refactor: Add fixtures for client in test files to speed them up
ogabrielluiz added a commit that referenced this pull request Aug 27, 2024
refactor: Add fixtures for client in test files to speed them up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants