Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance Chroma Handling, Bug Fixes & add GoogleGenerativeAIEmbeddingsComponent #3476

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

hotamago
Copy link
Contributor

@hotamago hotamago commented Aug 21, 2024

This pull request addresses a bug in the chroma_collection_to_data function and introduces the GoogleGenerativeAIEmbeddingsComponent for improved chroma handling.

Bug Fixes:

  • Chroma.py: Fixed a bug related to the limit parameter, ensuring it behaves as intended.
  • vectorstores/utils.py: Added a check in the chroma_collection_to_data function to handle cases where metadata might be None. This prevents potential errors.

New Feature:

  • Introduces the GoogleGenerativeAIEmbeddingsComponent to enhance chroma processing.
    • This component provides functionalities for Embedding using Google Embeddings
    • It automatically resizes vector embeddings to 1536 for chroma data, ensuring compatibility with downstream tasks.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working enhancement New feature or request labels Aug 21, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body
Pull request has a valid title

Result

Pull request is invalid.

Reason

  • Pull request title does not follow the desired pattern

Last Modified at 21 Aug 24 15:27 UTC

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3476.dmtpw4p5recq1.amplifyapp.com

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hotamago

Thanks for the fixes.

Looking good!

Could you write a better PR title, please?

@hotamago hotamago changed the title Fix bug of common function, fix Chroma script, Add GoogleGenerativeAIEmbeddingsComponent Fix bug in chroma_collection_to_data, Chroma.py. Add GoogleGenerativeAIEmbeddingsComponent Aug 22, 2024
…veAIEmbeddings.py

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
@hotamago hotamago changed the title Fix bug in chroma_collection_to_data, Chroma.py. Add GoogleGenerativeAIEmbeddingsComponent Enhance Chroma Handling: Bug Fixes & GoogleGenerativeAIEmbeddingsComponent Aug 22, 2024
@hotamago hotamago changed the title Enhance Chroma Handling: Bug Fixes & GoogleGenerativeAIEmbeddingsComponent feat: enhance Chroma Handling: Bug Fixes & GoogleGenerativeAIEmbeddingsComponent Aug 22, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Aug 22, 2024
@hotamago hotamago changed the title feat: enhance Chroma Handling: Bug Fixes & GoogleGenerativeAIEmbeddingsComponent Enhance Chroma Handling: Bug Fixes & GoogleGenerativeAIEmbeddingsComponent Aug 22, 2024
@ogabrielluiz ogabrielluiz changed the title Enhance Chroma Handling: Bug Fixes & GoogleGenerativeAIEmbeddingsComponent feat: Enhance Chroma Handling, Bug Fixes & add GoogleGenerativeAIEmbeddingsComponent Aug 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 22, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 22, 2024
@ogabrielluiz ogabrielluiz merged commit 2896c72 into langflow-ai:main Aug 23, 2024
28 checks passed
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
…ddingsComponent (#3476)

* Update Chroma.py

* Update utils.py

* Create GoogleGenerativeAIEmbeddings.py

* Update __init__.py

* Update GoogleGenerativeAIEmbeddings.py

* [autofix.ci] apply automated fixes

* Update src/backend/base/langflow/components/embeddings/GoogleGenerativeAIEmbeddings.py

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
ogabrielluiz added a commit that referenced this pull request Aug 27, 2024
…ddingsComponent (#3476)

* Update Chroma.py

* Update utils.py

* Create GoogleGenerativeAIEmbeddings.py

* Update __init__.py

* Update GoogleGenerativeAIEmbeddings.py

* [autofix.ci] apply automated fixes

* Update src/backend/base/langflow/components/embeddings/GoogleGenerativeAIEmbeddings.py

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants