Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto login hooks order bug #3472

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: auto login hooks order bug #3472

merged 2 commits into from
Aug 21, 2024

Conversation

lucaseduoli
Copy link
Collaborator

Fix bug where the auto login calling a hook makes the hook orders change and the application fail

@lucaseduoli lucaseduoli requested a review from anovazzi1 August 21, 2024 14:32
@lucaseduoli lucaseduoli self-assigned this Aug 21, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Aug 21, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 21 Aug 24 14:34 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Aug 21, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3472.dmtpw4p5recq1.amplifyapp.com

@lucaseduoli lucaseduoli merged commit a5e366c into main Aug 21, 2024
20 checks passed
@lucaseduoli lucaseduoli deleted the fix/auto_login_hook_bug branch August 21, 2024 15:12
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
Fix auto login hooks order bug
ogabrielluiz pushed a commit that referenced this pull request Aug 27, 2024
Fix auto login hooks order bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants